Allow starting ingester in JOINING state to auto join #2565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csmarchbanks
force-pushed
the
init-joining-ingester
branch
from
1d1b803 to
e139a01
Compare
If an ingester crashes during token transfer, or fails to rollback a token transfer then it will start up with a ring entry in the JOINING state. This will mean the ingester will no longer auto join because it is not in the PENDING state, and cannot receive a transfer request either. It will just stay in the JOINING state until manually deleted and forgotten from the ring. Instead, handle this case upon init, and set the state back to PENDING. This will allow the newly started ingester to properly receive a transfer request or auto join. Signed-off-by: Chris Marchbanks <[email protected]>
csmarchbanks
force-pushed
the
init-joining-ingester
branch
from
e139a01 to
5fa8818
Compare
gouthamve
approved these changes
May 15, 2020
Contributor
gouthamve
left a comment
gouthamve
left a comment
There was a problem hiding this comment.
LGTM with nit (just an additional safety bit).
pstibrany
approved these changes
May 15, 2020
Contributor
|
Does this fix #2548 ? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ingester crashes during token transfer, or fails to rollback a
token transfer then it will start up with a ring entry in the JOINING
state. This will mean the ingester will no longer auto join because it
is not in the PENDING state, and cannot receive a transfer request
either. It will just stay in the JOINING state until manually deleted
and forgotten from the ring.
Instead, handle this case upon init, and set the state back to PENDING.
This will allow the newly started ingester to properly receive a
transfer request or auto join.
Signed-off-by: Chris Marchbanks [email protected]
What this PR does:
Which issue(s) this PR fixes:
Fixes #2508
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]