Skip to content

Conversation

@reeshika-h
Copy link
Contributor

  • Refactor assertions in tests to use assertNotNull for improved validation

- Introduced SanityReport class to generate test summaries and send reports to Slack.
- Updated logging in CSHttpConnection to use logger instead of printStackTrace.
- Modified error handling in Entry class to check for empty error messages.
- Updated dependency versions in pom.xml and added new dependencies.
- Added test configuration properties to .gitignore.
- Created send-report.sh script for running tests and sending reports.
AniketDev7
AniketDev7 previously approved these changes May 5, 2025
harshithad0703
harshithad0703 previously approved these changes May 5, 2025
Copy link
Contributor

@harshithad0703 harshithad0703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reeshika-h reeshika-h dismissed stale reviews from harshithad0703 and AniketDev7 via 10f0bd2 May 5, 2025 05:22
Copy link

@AniketDev7 AniketDev7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reeshika-h reeshika-h marked this pull request as ready for review May 6, 2025 12:42
@reeshika-h reeshika-h requested a review from a team as a code owner May 6, 2025 12:42
@reeshika-h reeshika-h merged commit 82e75af into development May 6, 2025
9 checks passed
@reeshika-h reeshika-h deleted the fix/DX-2420-pipeline-friendly branch May 21, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants