ci: install br_netfilter for test-in-lima jobs #4486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Swagat Bora <[email protected]>
|
I am not sure why my local tests did not catch this earlier, but somehow the enable_icc tests were getting skippes/not run. Leading me to think that this is only for the flaky tests. It is only in a recent run, I found the tests failing. Hopefully this covers all the cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4481, we added loading br_netfilter modules for jobs running in containers and host. However, I missed adding it for the jobs that run inside a lima VM causing certain tests (flaky almalinux) to fail.
cc @AkihiroSuda