Skip to content

exec: wait for I/O completion before return #4392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

exec: wait for I/O completion before return #4392

merged 1 commit into from
Jul 1, 2025

Conversation

@swagatbora90
Copy link
Contributor

Fixes #4380

@swagatbora90
Copy link
Contributor Author

@apostasie PTAL

@apostasie
Copy link
Contributor

LGTM.

Failures are unrelated:

@apostasie
Copy link
Contributor

cc @AkihiroSuda for maintainers review & merge.

@apostasie
Copy link
Contributor

@swagatbora90 this is obviously in the same vein as #4383
We may have more of these.
Would you have time and interest in reviewing all similar patterns involving task IO in the codebase?

fahedouch
fahedouch approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fahedouch fahedouch added this to the v2.1.3 milestone Jul 1, 2025
@fahedouch fahedouch merged commit 02cfb57 into containerd:main Jul 1, 2025
35 of 38 checks passed
This was referenced Jul 1, 2025
Merged
Merged
@swagatbora90
Copy link
Contributor Author

Would you have time and interest in reviewing all similar patterns involving task IO in the codebase?

Yes, I can take a look. Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fahedouch fahedouch fahedouch approved these changes

+1 more reviewer

@apostasie apostasie apostasie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.1.3

Development

Successfully merging this pull request may close these issues.

[CI] TestComposeExec test is flaky

3 participants

@swagatbora90 @apostasie @fahedouch