Skip to content

[CI] more tests cleanup #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2025
Merged

[CI] more tests cleanup #4266

merged 4 commits into from
May 21, 2025

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented May 18, 2025 •
edited
Loading

On top of #4203 and #4209

In a shell:

  • remove compose yaml version field (deprecated, only adds noise to the logs)
  • remove useless port bindings preventing parallelization
  • move some tests from Alpine to Common
  • use data.Temp() for assets to simplify temp files handling

@apostasie apostasie force-pushed the 2025-05-more-tests branch from 26af4fd to bd4224a Compare May 18, 2025 20:49
@apostasie apostasie changed the title [WIP] tests work [CI] more tests cleanup May 18, 2025
@apostasie apostasie force-pushed the 2025-05-more-tests branch from bd4224a to 9d37987 Compare May 20, 2025 18:24
@apostasie apostasie marked this pull request as ready for review May 20, 2025 19:54
@apostasie apostasie closed this May 20, 2025
@apostasie apostasie reopened this May 20, 2025
@apostasie apostasie force-pushed the 2025-05-more-tests branch from 9d37987 to 01c83c7 Compare May 20, 2025 22:29
@AkihiroSuda AkihiroSuda added this to the v2.1.3 milestone May 21, 2025
AkihiroSuda
AkihiroSuda approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 1d88823 into containerd:main May 21, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.1.3

Development

Successfully merging this pull request may close these issues.

2 participants

@apostasie @AkihiroSuda