[CI]: quality of life: minor debugging output fixes #4111
Conversation
apostasie
commented
Apr 16, 2025
apostasie
commented
- commit 1 has a few assorted minor fixes and changes (see commit message for details)
- commit 2 does make use of recently introduced env Whitelisting to tame Environ display
| timeout := gc.Timeout | ||
| if timeout == 0 { | ||
| timeout = defaultTimeout | ||
| if gc.Timeout == 0 { |
There was a problem hiding this comment.
Fix 0s being displayed (instead of displaying defaultTimeout) when no explicit timeout has been passed.
| Stderr string | ||
| ExitCode int | ||
| Signal os.Signal | ||
| Duration time.Duration |
There was a problem hiding this comment.
Store command execution time.
|
|
||
| if len(chunks) > maxLines { | ||
| chunks = append(chunks[0:maxLines], "...") | ||
| abbreviator := "..." |
There was a problem hiding this comment.
Instead of stripping anything after line maxLines, we now keep maxLines/2 from the start and from the end.
|
|
||
| duration := result.Duration.String() | ||
| if result.Duration < time.Second { | ||
| duration = "<1s" |
There was a problem hiding this comment.
Do not want to see 123.456789ms
| []any{"Environ", strings.Join(result.Environ, "\n")}, | ||
| []any{envDecorator, strings.Join(result.Environ, "\n")}, | ||
| []any{timeoutDecorator, duration + " (limit: " + gc.cmd.Timeout.String() + ")"}, | ||
| []any{cwdDecorator, gc.cmd.WorkingDir}, |
There was a problem hiding this comment.
Show cwd and better duration info.
| "NETCONFPATH", | ||
| "NERDCTL_EXPERIMENTAL", | ||
| "NERDCTL_HOST_GATEWAY_IP", | ||
| ret.WithWhitelist([]string{ |
There was a problem hiding this comment.
Use whitelist to tame os.Environ on the CI.
apostasie
force-pushed
the
ci-fix-debug
branch
2 times, most recently
from
acaa710 to
ace5258
Compare
|
Failures are unrelated (#3556 and some old logs issue in legacy tests) |
- fix timeout showing 0s instead of default when no explicit timeout is provided - add actual execution time - fix long logs (stdout, stderr) that were showing only the beginning to also show the end - fix formatting issue for "..." - marginally better output for command contextual information Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
|
Rebased to get another CI run with #4104 fix. |
|
Latest failure is #3510, My hunch is that it is calling containerd Convert under the hood, which we know is buggy. |
2 participants
