Skip to content

[P0] [CI] Adjust drifting test #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

[P0] [CI] Adjust drifting test #4058

merged 1 commit into from
Apr 1, 2025

Conversation

@apostasie
Copy link
Contributor

@apostasie apostasie commented Mar 30, 2025 •
edited
Loading

Spotted in #4056, but will trip every PR from now on.

Fix is: ignoring the problem for another year 😆.

@apostasie apostasie changed the title Adjust drifting test [CI] Adjust drifting test Mar 30, 2025
@apostasie apostasie changed the title [CI] Adjust drifting test [PRIORITY] [CI] Adjust drifting test Mar 30, 2025
@apostasie apostasie mentioned this pull request Mar 30, 2025
Merged
2 tasks
@apostasie
Copy link
Contributor Author

CI failures are a network fluke, and infamous #3513

@apostasie apostasie mentioned this pull request Mar 31, 2025
Merged
@apostasie apostasie changed the title [PRIORITY] [CI] Adjust drifting test [P0] [CI] Adjust drifting test Apr 1, 2025
AkihiroSuda
AkihiroSuda approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm merging this, but this shouldn't be hard-coded

@AkihiroSuda AkihiroSuda added this to the v2.0.5 milestone Apr 1, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Apr 1, 2025
@AkihiroSuda AkihiroSuda merged commit 00558aa into containerd:main Apr 1, 2025
28 of 30 checks passed
@apostasie
Copy link
Contributor Author

Thanks, I'm merging this, but this shouldn't be hard-coded

Agreed...

@apostasie apostasie mentioned this pull request Apr 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/ci e.g., CI failure

Projects

None yet

Milestone

v2.0.5

Development

Successfully merging this pull request may close these issues.

2 participants

@apostasie @AkihiroSuda