-
Couldn't load subscription status.
- Fork 710
[CI] Tigron breakout 3: leak detection #4044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
77668dd to
5f05542
Compare
|
Note: some discussion on the master PR:
|
9e0e10a to
bc8b0b0
Compare
|
Rebased. |
c450d20 to
5d5f5c3
Compare
Signed-off-by: apostasie <[email protected]>
5d5f5c3 to
c9c90d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
buildg failure logged in #4046 |
On top of the two previous breakouts.
This PR adds
internal/highkin preparation for the command rewrite.Currently, the implementation relies on Uber library for go routines, and on parsing the output of lsof for fd.
I have used it intensively while rewriting Command. It has been very useful so far, but it certainly needs more work.
Proposal is to first start using it internally for Tigron own testing (as for the upcoming Command), hammer the kinks and then consider adding it as a feature of the test framework.
For an example on how it can be used at this point:
nerdctl/mod/tigron/internal/com/package_test.go
Lines 55 to 95 in 958c566