GHA cache image build dependencies #3583
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,47 @@ env: | |
| LONG_TIMEOUT: 60 | ||
|
|
||
| jobs: | ||
| # This job builds the dependency target of the test docker image for all supported architectures and cache it in GHA | ||
| build-dependencies: | ||
| timeout-minutes: 10 | ||
| name: dependencies | ${{ matrix.containerd }} | ${{ matrix.arch }} | ||
| runs-on: "${{ matrix.runner }}" | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - runner: ubuntu-24.04 | ||
| containerd: v1.6.36 | ||
| arch: amd64 | ||
| - runner: ubuntu-24.04 | ||
| containerd: v1.7.23 | ||
| arch: amd64 | ||
| - runner: ubuntu-24.04 | ||
| containerd: v2.0.0-rc.5 | ||
| arch: amd64 | ||
| - runner: arm64-8core-32gb | ||
| containerd: v2.0.0-rc.5 | ||
| arch: arm64 | ||
| env: | ||
| CONTAINERD_VERSION: "${{ matrix.containerd }}" | ||
| ARCH: "${{ matrix.arch }}" | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| with: | ||
| fetch-depth: 1 | ||
| - name: "Expose GitHub Runtime variables for gha" | ||
| uses: crazy-max/ghaction-github-runtime@v3 | ||
| - name: "Build dependencies for the integration test environment image" | ||
| run: | | ||
| docker buildx create --name with-gha --use | ||
| docker buildx build \ | ||
| --output=type=docker \ | ||
| --cache-to type=gha,mode=max,scope=${ARCH}-${CONTAINERD_VERSION} \ | ||
| --cache-from type=gha,scope=${ARCH}-${CONTAINERD_VERSION} \ | ||
| --target build-dependencies --build-arg CONTAINERD_VERSION=${CONTAINERD_VERSION} . | ||
|
|
||
| test-unit: | ||
| # FIXME: | ||
| # Supposed to work: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#example-returning-a-json-data-type | ||
| # Apparently does not | ||
| # timeout-minutes: ${{ fromJSON(env.SHORT_TIMEOUT) }} | ||
|
|
@@ -56,7 +96,8 @@ jobs: | |
| run: make test-unit | ||
|
|
||
| test-integration: | ||
| needs: build-dependencies | ||
| timeout-minutes: 30 | ||
| name: rootful | ${{ matrix.containerd }} | ${{ matrix.runner }} | ||
| runs-on: "${{ matrix.runner }}" | ||
| strategy: | ||
|
|
@@ -67,24 +108,36 @@ jobs: | |
| - ubuntu: 20.04 | ||
| containerd: v1.6.36 | ||
| runner: "ubuntu-20.04" | ||
| arch: amd64 | ||
| - ubuntu: 22.04 | ||
| containerd: v1.7.23 | ||
| runner: "ubuntu-22.04" | ||
| arch: amd64 | ||
| - ubuntu: 24.04 | ||
| containerd: v2.0.0-rc.5 | ||
| runner: "ubuntu-24.04" | ||
| arch: amd64 | ||
| - ubuntu: 24.04 | ||
| containerd: v2.0.0-rc.5 | ||
| runner: arm64-8core-32gb | ||
| arch: arm64 | ||
| env: | ||
| CONTAINERD_VERSION: "${{ matrix.containerd }}" | ||
| ARCH: "${{ matrix.arch }}" | ||
| UBUNTU_VERSION: "${{ matrix.ubuntu }}" | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| with: | ||
| fetch-depth: 1 | ||
| - name: "Expose GitHub Runtime variables for gha" | ||
| uses: crazy-max/ghaction-github-runtime@v3 | ||
| - name: "Prepare integration test environment" | ||
| run: | | ||
| docker buildx create --name with-gha --use | ||
| docker buildx build \ | ||
| --output=type=docker \ | ||
| --cache-from type=gha,scope=${ARCH}-${CONTAINERD_VERSION} \ | ||
| -t test-integration --target test-integration --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} --build-arg CONTAINERD_VERSION=${CONTAINERD_VERSION} . | ||
| - name: "Remove snap loopback devices (conflicts with our loopback devices in TestRunDevice)" | ||
| run: | | ||
| sudo systemctl disable --now snapd.service snapd.socket | ||
|
|
@@ -106,19 +159,21 @@ jobs: | |
| run: docker run -t --rm --privileged test-integration ./hack/test-integration.sh -test.only-flaky=true | ||
|
|
||
| test-integration-ipv6: | ||
| needs: build-dependencies | ||
| timeout-minutes: 10 | ||
| name: ipv6 | ${{ matrix.containerd }} | ${{ matrix.ubuntu }} | ||
| runs-on: "ubuntu-${{ matrix.ubuntu }}" | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - ubuntu: 24.04 | ||
| containerd: v2.0.0-rc.5 | ||
| arch: amd64 | ||
| env: | ||
| CONTAINERD_VERSION: "${{ matrix.containerd }}" | ||
| ARCH: "${{ matrix.arch }}" | ||
| UBUNTU_VERSION: "${{ matrix.ubuntu }}" | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| with: | ||
|
|
@@ -127,13 +182,20 @@ jobs: | |
| run: | | ||
| sudo sysctl -w net.ipv6.conf.all.forwarding=1 | ||
| sudo sysctl -w net.ipv4.ip_forward=1 | ||
| - name: "Expose GitHub Runtime variables for gha" | ||
| uses: crazy-max/ghaction-github-runtime@v3 | ||
| - name: Enable IPv6 for Docker, and configure docker to use containerd for gha | ||
| run: | | ||
| sudo mkdir -p /etc/docker | ||
| echo '{"ipv6": true, "fixed-cidr-v6": "2001:db8:1::/64", "experimental": true, "ip6tables": true}' | sudo tee /etc/docker/daemon.json | ||
| sudo systemctl restart docker | ||
| - name: "Prepare integration test environment" | ||
| run: | | ||
| docker buildx create --name with-gha --use | ||
| docker buildx build \ | ||
| --output=type=docker \ | ||
| --cache-from type=gha,scope=${ARCH}-${CONTAINERD_VERSION} \ | ||
| -t test-integration --target test-integration --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} --build-arg CONTAINERD_VERSION=${CONTAINERD_VERSION} . | ||
| - name: "Remove snap loopback devices (conflicts with our loopback devices in TestRunDevice)" | ||
| run: | | ||
| sudo systemctl disable --now snapd.service snapd.socket | ||
|
|
@@ -158,7 +220,8 @@ jobs: | |
| run: docker run --network host -t --rm --privileged test-integration ./hack/test-integration.sh -test.only-ipv6 | ||
|
|
||
| test-integration-rootless: | ||
| needs: build-dependencies | ||
| timeout-minutes: 30 | ||
| name: "${{ matrix.target }} | ${{ matrix.containerd }} | ${{ matrix.rootlesskit }} | ${{ matrix.ubuntu }}" | ||
| runs-on: "ubuntu-${{ matrix.ubuntu }}" | ||
| strategy: | ||
|
|
@@ -170,21 +233,26 @@ jobs: | |
| containerd: v1.6.36 | ||
| rootlesskit: v1.1.1 # Deprecated | ||
| target: rootless | ||
| arch: amd64 | ||
| - ubuntu: 22.04 | ||
| containerd: v1.7.23 | ||
| rootlesskit: v2.3.1 | ||
| target: rootless | ||
| arch: amd64 | ||
| - ubuntu: 24.04 | ||
| containerd: v2.0.0-rc.5 | ||
| rootlesskit: v2.3.1 | ||
| target: rootless | ||
| arch: amd64 | ||
| - ubuntu: 24.04 | ||
| containerd: v1.7.23 | ||
| rootlesskit: v2.3.1 | ||
| target: rootless-port-slirp4netns | ||
| arch: amd64 | ||
| env: | ||
| CONTAINERD_VERSION: "${{ matrix.containerd }}" | ||
| ARCH: "${{ matrix.arch }}" | ||
| UBUNTU_VERSION: "${{ matrix.ubuntu }}" | ||
| ROOTLESSKIT_VERSION: "${{ matrix.rootlesskit }}" | ||
| TEST_TARGET: "test-integration-${{ matrix.target }}" | ||
| steps: | ||
|
|
@@ -215,8 +283,15 @@ jobs: | |
| docker run --privileged --rm tonistiigi/binfmt --install linux/amd64 | ||
| docker run --privileged --rm tonistiigi/binfmt --install linux/arm64 | ||
| docker run --privileged --rm tonistiigi/binfmt --install linux/arm/v7 | ||
| - name: "Expose GitHub Runtime variables for gha" | ||
| uses: crazy-max/ghaction-github-runtime@v3 | ||
| - name: "Prepare (network driver=slirp4netns, port driver=builtin)" | ||
| run: | | ||
| docker buildx create --name with-gha --use | ||
| docker buildx build \ | ||
| --output=type=docker \ | ||
| --cache-from type=gha,scope=${ARCH}-${CONTAINERD_VERSION} \ | ||
| -t ${TEST_TARGET} --target ${TEST_TARGET} --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} --build-arg CONTAINERD_VERSION=${CONTAINERD_VERSION} --build-arg ROOTLESSKIT_VERSION=${ROOTLESSKIT_VERSION} . | ||
| - name: "Disable BuildKit for RootlessKit v1 (workaround for issue #622)" | ||
| run: | | ||
| # https://github.com/containerd/nerdctl/issues/622 | ||
|
|
@@ -250,7 +325,7 @@ jobs: | |
| run: GO_VERSION="$(echo ${{ matrix.go-version }} | sed -e s/.x//)" make binaries | ||
|
|
||
| test-integration-docker-compatibility: | ||
| timeout-minutes: 30 | ||
| name: docker | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
|
|
@@ -262,11 +337,6 @@ jobs: | |
| go-version: ${{ env.GO_VERSION }} | ||
| cache: true | ||
| check-latest: true | ||
|
There was a problem hiding this comment. Debugging remnants. |
||
| - name: "Register QEMU (tonistiigi/binfmt)" | ||
| run: | | ||
| # `--install all` will only install emulation for architectures that cannot be natively executed | ||
|
|
@@ -324,13 +394,14 @@ jobs: | |
| run: ./hack/test-integration.sh -test.only-flaky=true | ||
|
|
||
| test-integration-freebsd: | ||
| timeout-minutes: 30 | ||
| name: FreeBSD | ||
| # ubuntu-24.04 lacks the vagrant package | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| with: | ||
|
|
||
| fetch-depth: 1 | ||
| - uses: actions/cache@v4 | ||
| with: | ||
| path: /root/.vagrant.d | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lower timeouts.