Change compose lock to use DataStore() #3563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
compose-lock-take-2
branch
from
2f6d50f to
84b4d94
Compare
This was referenced Oct 17, 2024
Merged
Merged
apostasie
changed the title
Contributor
Author
|
@AkihiroSuda at your convenience. |
Contributor
Author
|
@djdongjin if you are still around, I can use this to fix CI bustage on upcoming PRs (specifically #3535) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare (?) circumstances, DataRoot might not exist yet (eg: fresh install, first command being run being a
composecommand).Changing the lock location to rely on
DataStore()instead, which does provide existence guarantee (and is also a bit more specific).Failure was seen on unmerged PRs CI runs when parallelization triggered an execution order that produced the situation above.