Skip to content

Conversation

@xyz-li
Copy link
Contributor

@xyz-li xyz-li commented Sep 26, 2024

nerdctl images --filter before=not-exist-image will panic.

Fix: #3467

Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Would you mind adding a test case to TestImagesFilter to validate providing before and since filter for an image that does not exist?

@apostasie
Copy link
Contributor

CI failures notes:

@apostasie
Copy link
Contributor

Tagging @djdongjin @AkihiroSuda for maintainers review.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit cd4a62a into containerd:main Sep 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nerdctl images filter panic

4 participants