Skip to content

Conversation

@apostasie
Copy link
Contributor

@apostasie apostasie commented Sep 23, 2024

This is a first follow-up to #3418, rewriting more tests to leverage the new tooling.

In almost all cases, this is "identical" with the previous state of affairs, as these changes are not meant to introduce new tests, and normally do not radically change the existing tests intention.

However, here or in upcoming follow-ups:

  • "requirements" have been precisely reviewed
    • some tests that were previously not "private" are now properly isolated
    • some tests that were previously not running for Docker (or other previously overstated requirements) will now run
  • all tests are now parallelized by default

I appreciate this is hard to review.
This is a full-on rewrite.
But then, we are talking solely about tests here, with no code or logic change - and the proof is in the pudding: aka green CI.

I am splitting different subfolders tests in different commits.
As I am converting more tests, I will add more commits to this branch.

We should still merge this PR whenever convenient (pending green of course) - and I will just open more PRs - that should help keep this bite-size and avoid conflicting with main.

@apostasie apostasie force-pushed the qa-nextgen branch 4 times, most recently from e5cec64 to 4501e0f Compare September 23, 2024 17:57
@apostasie apostasie marked this pull request as ready for review September 23, 2024 18:34
@apostasie apostasie changed the title [WIP] test rework, part 2 Test rework, part 2 Sep 23, 2024
@apostasie
Copy link
Contributor Author

@AkihiroSuda let's merge this if these changes are fine with you.
I am in testing hell in other PRs, and any improvement overall to the tests stability and isolation will help.

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Sep 25, 2024
@AkihiroSuda AkihiroSuda requested review from a team and removed request for a team September 25, 2024 14:01
@apostasie
Copy link
Contributor Author

Last push does rebase, and simplify completion-test to not flake.

@apostasie
Copy link
Contributor Author

Failures with last push are the perennial IPFS/Compose, and testattach (current delay is definitely too short - will fix separately at 5 seconds which seems to do the trick).

@apostasie apostasie mentioned this pull request Sep 25, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 334cc2f into containerd:main Sep 27, 2024
22 checks passed
@apostasie apostasie mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants