Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS
Fixed:
expected acArg to be "docker.io", got "registry-1.docker.io") #3245 (cc @lingdie ):docker.ioindex.docker.io, with or without port443, with or without scheme, will all be treated as meant for "docker hub" and use whatever credentials are associated with it--insecure-registry=false(and treating it differently from "no flag"), which allows the user to override the default behavior for localhost (default behavior being to treat localhost as always insecure)nerdctl loginshould warn about passing along an explicit scheme #3052httpscheme is explicitly used in front of the server url, we are now warning the user that the scheme is ignored entirely and that our behavior is governed by the use of the insecure flag (which is the current behavior)Other changes:
IsErrHTTPResponseToHTTPSClient, ashttp.ErrSchemeMismatchis usable in placeTODO:
To be confirmed:
no route to host) #299Currently NOT addressed:
nerdctl pushinterop issue with Harbor registry #1675