Skip to content

Conversation

weyert
Copy link
Contributor

@weyert weyert commented May 9, 2025

What

Updated semaphore.yml to add support for Node.js v24.

Used the ABI version as listed in the JSON file located at: https://github.com/nodejs/node/blob/main/doc/abi_version_registry.json

fixes #306

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

No testing done. Unclear how to run semaphore.yml file

Open questions / Follow-ups

Updated `semaphore.yml ` to add support for Node.js v24.  Used the ABI version as listed in the JSON file located at: 
https://github.com/nodejs/node/blob/main/doc/abi_version_registry.json
@weyert
Copy link
Contributor Author

weyert commented May 16, 2025

Any plans to merge this?

@milindl
Copy link
Contributor

milindl commented May 21, 2025

@weyert , yep, do you mind if I take your commit into an internal branch and merge it that way? I can't tag a commit on an external branch (to check building of binaries for all supported platforms).

@weyert
Copy link
Contributor Author

weyert commented Jun 14, 2025

@weyert , yep, do you mind if I take your commit into an internal branch and merge it that way? I can't tag a commit on an external branch (to check building of binaries for all supported platforms).

Sure, no problem :)

@milindl
Copy link
Contributor

milindl commented Jul 3, 2025

Closing with merge into master and now that 1.4.0 is released, thanks @weyert

@milindl milindl closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Node v24
3 participants