Skip to content

Conversation

milindl
Copy link
Contributor

@milindl milindl commented Dec 13, 2024

Adds error types to declaration. Re-exports error codes as needed. Also removes unused error.

@milindl milindl requested review from a team as code owners December 13, 2024 11:12
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but there's a linting error to fix in

src/admin.cc:1001:  Lines should be <= 80 characters long  [whitespace/line_length] [2]

In semaphore.yml could you change name: "ESLint" to name: "Lint" and run make lint instead?

For the rest it looks good.

@milindl milindl merged commit e516d31 into master Dec 15, 2024
2 checks passed
@milindl milindl deleted the err_types_minor_err_msgs branch December 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants