Update versions to support spring boot #117
Conversation
|
It looks like @ryan-barker-zefr hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
There was a problem hiding this comment.
@ryan-barker-zefr I'm not sure I understand why we would want to merge changes like these. Why would version numbers, and how we even name them, change here?
4.0.x is a release branch that we would use for any future 4.0.x releases, which is why its version is currently marked 4.0.2-SNAPSHOT -- we released 4.0.0 and 4.0.1 in that release line and if we need to release a 4.0.2, we would base it off this code and all the version numbers would change to 4.0.2 (dropping the SNAPSHOT). So all the changes here would end up reverted anyway....
|
This was necessary to build the rest utils project due to parent pom being
in another repo. I agree this change does nothing for you.
The only real change was an upgrade of jetty and jersey versions for rest
utils.
…On Mon, May 7, 2018, 1:52 PM Ewen Cheslack-Postava ***@***.***> wrote:
***@***.**** commented on this pull request.
@ryan-barker-zefr <https://github.com/ryan-barker-zefr> I'm not sure I
understand why we would want to merge changes like these. Why would version
numbers, and how we even name them, change here?
4.0.x is a release branch that we would use for any future 4.0.x releases,
which is why its version is currently marked 4.0.2-SNAPSHOT -- we released
4.0.0 and 4.0.1 in that release line and if we need to release a 4.0.2, we
would base it off this code and all the version numbers would change to
4.0.2 (dropping the SNAPSHOT). So all the changes here would end up
reverted anyway....
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#117 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWcfix430emdcTMz44ixrM8-YmHlqNwPks5twLQjgaJpZM4Tv76o>
.
|
|
closing, since 4.x is no longer supported |
3 participants
There will be a corresponding pull request on common-docker and another on rest-utils
This is required to utilize the rest-utils for unit tests in a spring boot application
https://github.com/ZEFR-INC/kafka-kstreams-kotlin-example-app
The basic issue is that spring boot requires newer versions of jetty and jersey while confluent is stuck on old versions. Relatively minor changes are required to make this work, but it does require java 8 per comments (not tested). Considering java 7 has been end of life since April 2015 https://www.java.com/en/download/faq/java_7.xml I think this is reasonable.
Please feel free to fork the kotlin example app to include as a sample kstream app for kotlin. It's only non-public dependency is some compiled avro files that could be easily switched to some other avro files.