fix for panic on http error #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before that change http error triggered the following error:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x7f1153]
goroutine 1 [running]:
github.com/concourse/retryhttp.(*RetryRoundTripper).RoundTrip.func1()
github.com/concourse/[email protected]/retry_round_tripper.go:57 +0xf3
after the change the right message is shown:
failed to ping registry: 2 errors occurred:
* ping https: Get "https://registry-1.docker.io/v2/": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Signed-off-by: Pavel Merdin <[email protected]>
Contributor
Author
|
Related to concourse/retryhttp#17 |
taylorsilva
approved these changes
Nov 15, 2025
Member
|
Thanks again for both PR's! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before that change http error triggered the following error:
after the change the right message is shown: