Refactor gem repo into defined type #23
Conversation
* Also changes elsif blocks for a case statement
|
@ice799 any chance of a review? 👍 |
|
sorry for the delay! i'm going to take a look now. |
|
the changes look fine to me, thanks a lot for your work on this and your patience with my slow review. i'm going to re-run the specs one more time right now just to be safe and once they pass I'll merge this change. |
|
@petems hmmm.... I'm getting a kitchen failure for i'm investigating now |
manifests/repo.pp
Outdated
| 'RedHat', 'redhat', 'CentOS', 'centos', 'Amazon', 'Fedora', 'Scientific', 'OracleLinux', 'OEL': { | ||
|
|
||
| $majrel = $::osreleasemaj | ||
| if $::pygpgme_installed == false { |
There was a problem hiding this comment.
it appears that this check is failing, for some reason, on default-centos-510
There was a problem hiding this comment.
ah, yes, this is because $::pygpgme_installed is a string, not a truthy value. looks like in the refactor it got switched to a truthy. there was a reason why i made $::pygpgme_installed be a string instead of a truthy originally. it was something about facter functions, but i can't remember why.
if you commit a change to change this back to a string comparison, that should fix the spec and i can merge this.
* Also adds coverage class
petems
force-pushed
the
refactor_gem_repo_into_defined_type
branch
from
ef108c6 to
79cc043
Compare
2 participants
Moves gem repo into new defined type
I'm going to refactor the others, but I thought I'd make the changes in manageable chunks
Also added working rspec tests for the new gem_repo defined type
I ran the test-kitchen tests and everything passed, so functionality is the same 👍