Skip to content

Add Cycle ORM configuration finalization and heap cleaning #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

roxblnfk
Copy link
Contributor

Hi. I see that you don't use ORM warming up after configuration is complete. Also, following the doctrine analogy, I added entity cache clearing.

@compositephp
Copy link
Owner

I attempted to adhere to the official project documentation, and I noticed that there is no mention of prepareServices() on the Cycle ORM website at https://cycle-orm.dev/docs
But ok, the goal of the benchmark is to measure the speed at which the ORM executes SQL queries and maps the data, not its initialization time.

@compositephp compositephp merged commit 95b1ac2 into compositephp:master Dec 26, 2023
@roxblnfk roxblnfk deleted the fix-cycle-bench branch December 26, 2023 16:33
@roxblnfk
Copy link
Contributor Author

roxblnfk commented Dec 26, 2023

Yes, this function is used in bridges, but it is not described in the documentation.

In addition, ORM Schema compilation usually doesn't run in a production environment, but is loaded from the cache. This can affect the Memory Peak metric.
Perhaps it would be more correct to set the schema manually, rather than parsing files and attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants