Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .jshintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"asi": true,
"curly": false,
"eqeqeq": false,
"eqnull": true,
"immed": true,
"latedef": "nofunc",
"laxbreak": true,
"mocha" : true,
"newcap": true,
"noarg": true,
"browser": true,
"shadow": true,
"sub": true,
"undef": true,
"unused": true,
"globals": {
"exports": false,
"require": false,
"module": false
}

}
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,7 @@ clean:
test:
@./node_modules/.bin/component-test phantom

lint:
@./node_modules/.bin/jshint index.js lib test

.PHONY: clean test
2 changes: 1 addition & 1 deletion lib/css.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,5 @@ function css(el, prop, extra, styles) {
*/

function isNumeric(obj) {
return !isNan(parseFloat(obj)) && isFinite(obj);
return !isNaN(parseFloat(obj)) && isFinite(obj);
}
4 changes: 2 additions & 2 deletions lib/hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ each(['width', 'height'], function(name) {
}

exports[name].set = function(el, val, extra) {
var styles = extra && styles(el);
var elStyles = extra && styles(el);
return setPositiveNumber(el, val, extra
? augmentWidthOrHeight(el, name, extra, 'border-box' == css(el, 'boxSizing', false, styles), styles)
? augmentWidthOrHeight(el, name, extra, 'border-box' == css(el, 'boxSizing', false, elStyles), elStyles)
: 0
);
};
Expand Down
1 change: 0 additions & 1 deletion lib/prop.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
*/

var debug = require('debug')('css:prop');
var camelcase = require('to-camel-case');
var vendor = require('./vendor');

/**
Expand Down
2 changes: 2 additions & 0 deletions lib/swap.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ module.exports = swap;
*/

function swap(el, options, fn, args) {
var old = {}, ret;

// Remember the old values, and insert the new ones
for (var key in options) {
old[key] = el.style[key];
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@
"component-each": "~0.2.2"
},
"devDependencies": {
"component-test2": "*",
"domify": "^1.2.2",
"load-styles": "^1.0.1",
"component-test2": "*"
"jshint": "^2.7.0",
"load-styles": "^1.0.1"
},
"browser": {
"each": "component-each"
Expand Down