GHA: correct ternary to avoid passing -fuse-ld=lld
#1050
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
Steelskin,
Copilot,
mhegazy and
speednoisemovement
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
compnerd
force-pushed
the
compnerd/incorrect
branch
from
a56fd9d to
b63796e
Compare
This flag is not supported by MSVC, ensuire that we do not improperly pass this to the flags. This is a u-opt to ensure that we do not need to see the output and avoid the unnecessary processing for the invalid argument.
compnerd
force-pushed
the
compnerd/incorrect
branch
from
b63796e to
abcd42f
Compare
Steelskin
approved these changes
Oct 31, 2025
|
Going to close this as @speednoisemovement has a working fix for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is not supported by MSVC, ensuire that we do not improperly pass this to the flags. This is a u-opt to ensure that we do not need to see the output and avoid the unnecessary processing for the invalid argument.