Update action.yml #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a compatibility shim for older releases.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a compatibility shim for older releases by providing a legacy module map entry for WinSDK in the action configuration.
- Adds a "(Legacy) WinSDK Module Map" entry to maintain backward compatibility
- Uses the same source URL as the current WinSDK(UM) Module Map but with a different destination path
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+234
to
+237
| "(Legacy) WinSDK Module Map" = @{ | ||
| URL = "https://raw.githubusercontent.com/swiftlang/swift/main/stdlib/public/Platform/winsdk_um.modulemap"; | ||
| Destination = "$([IO.Path]::Combine("${env:SDKROOT}", "usr", "share", "winsdk.modulemap"))"; | ||
| }; |
There was a problem hiding this comment.
[nitpick] The legacy and current module maps point to the same source URL but different destinations. Consider adding a comment explaining why both entries are needed and when the legacy entry can be safely removed to help future maintainers understand the compatibility requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a compatibility shim for older releases.