-
Notifications
You must be signed in to change notification settings - Fork 15
GHA: add the ability to update the module map #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c0724a5 to
89e3d42
Compare
action.yml
Outdated
| $SwiftRoot = Split-Path -Path (Split-Path -Path (Get-Command swift).Source -Parent) -Parent | ||
| $SwiftClangIncludeFolder = Join-Path $SwiftRoot "lib" "swift" "clang" "include" | ||
| curl -s ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to add the token to this URL like this:
-H "Authorization: Bearer ${{ github.token }}" `
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I explicitly removed it (given the suggestion from CoPilot). It risks exposing the token and is unnecessary as per CoPilot since it is a public repo.
62a271c to
8a617e1
Compare
953b413 to
7b27bcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new option to update Windows SDK modularization definitions to the latest versions from the Swift and LLVM repositories. It adds the ability to automatically download the most recent module maps and API notes for Windows SDK components.
- Adds
update-sdk-modulesboolean input parameter for Windows-only SDK module updates - Implements PowerShell script to download latest module definitions from GitHub repositories
- Includes test workflow to verify the new functionality works correctly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| action.yml | Adds new input parameter and PowerShell step to download latest SDK module definitions |
| README.md | Documents the new update-sdk-modules parameter and reorganizes parameter sections |
| .github/workflows/test-install.yml | Adds test job to verify SDK module update functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
action.yml
Outdated
| } | ||
| $ModuleDefinitions.GetEnumerator() | ForEach-Object { | ||
| curl.exe -so "$($_.Value.Destination)" $_.Value.URL |
Copilot
AI
Aug 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using curl without SSL certificate verification or error handling for HTTPS downloads poses security risks. Consider adding SSL verification and proper error handling for network failures.
| curl.exe -so "$($_.Value.Destination)" $_.Value.URL | |
| curl.exe --fail --show-error --retry 3 --retry-delay 5 -so "$($_.Value.Destination)" $_.Value.URL |
2bfefc6 to
d6772a6
Compare
Introduce a new option to update the Windows SDK modularization to the latest version in Swift.
d6772a6 to
ad56ea0
Compare
Introduce a new option to update the Windows SDK modularization to the latest version in Swift.