Skip to content

Conversation

@compnerd
Copy link
Owner

Introduce a new option to update the Windows SDK modularization to the latest version in Swift.

@compnerd compnerd requested a review from Copilot August 27, 2025 20:29

This comment was marked as outdated.

@compnerd compnerd force-pushed the compnerd/update branch 3 times, most recently from c0724a5 to 89e3d42 Compare August 27, 2025 20:49
action.yml Outdated
$SwiftRoot = Split-Path -Path (Split-Path -Path (Get-Command swift).Source -Parent) -Parent
$SwiftClangIncludeFolder = Join-Path $SwiftRoot "lib" "swift" "clang" "include"
curl -s `

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to add the token to this URL like this:

-H "Authorization: Bearer ${{ github.token }}" `

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly removed it (given the suggestion from CoPilot). It risks exposing the token and is unnecessary as per CoPilot since it is a public repo.

@compnerd compnerd force-pushed the compnerd/update branch 2 times, most recently from 62a271c to 8a617e1 Compare August 27, 2025 23:06
@compnerd compnerd requested review from Steelskin and Copilot August 27, 2025 23:06

This comment was marked as outdated.

@compnerd compnerd requested a review from Copilot August 29, 2025 16:21

This comment was marked as outdated.

@compnerd compnerd requested a review from Copilot August 31, 2025 02:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new option to update Windows SDK modularization definitions to the latest versions from the Swift and LLVM repositories. It adds the ability to automatically download the most recent module maps and API notes for Windows SDK components.

  • Adds update-sdk-modules boolean input parameter for Windows-only SDK module updates
  • Implements PowerShell script to download latest module definitions from GitHub repositories
  • Includes test workflow to verify the new functionality works correctly

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
action.yml Adds new input parameter and PowerShell step to download latest SDK module definitions
README.md Documents the new update-sdk-modules parameter and reorganizes parameter sections
.github/workflows/test-install.yml Adds test job to verify SDK module update functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

action.yml Outdated
}
$ModuleDefinitions.GetEnumerator() | ForEach-Object {
curl.exe -so "$($_.Value.Destination)" $_.Value.URL
Copy link

Copilot AI Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using curl without SSL certificate verification or error handling for HTTPS downloads poses security risks. Consider adding SSL verification and proper error handling for network failures.

Suggested change
curl.exe -so "$($_.Value.Destination)" $_.Value.URL
curl.exe --fail --show-error --retry 3 --retry-delay 5 -so "$($_.Value.Destination)" $_.Value.URL

Copilot uses AI. Check for mistakes.
@compnerd compnerd force-pushed the compnerd/update branch 7 times, most recently from 2bfefc6 to d6772a6 Compare August 31, 2025 03:21
Introduce a new option to update the Windows SDK modularization to the
latest version in Swift.
@compnerd compnerd merged commit 9d3fb9d into main Aug 31, 2025
5 checks passed
@compnerd compnerd deleted the compnerd/update branch August 31, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants