GHA: rename parameters #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
force-pushed
the
compnerd/renaming
branch
from
d5a4cbf to
a5b7ff7
Compare
compnerd
force-pushed
the
compnerd/renaming
branch
from
a5b7ff7 to
160f571
Compare
Rename the `branch` and `tag` to `swift-version` and `swift-build` to aid in clarity. Additionally, correct the custom source handling on macOS and Linux. Fixes: #19
compnerd
force-pushed
the
compnerd/renaming
branch
from
160f571 to
06bacc1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR renames the branch and tag parameters to swift-version and swift-build respectively to improve clarity in the GitHub Action. The change maintains backward compatibility by keeping the old parameters as deprecated while adding validation logic to handle the transition.
- Renames
branch→swift-versionandtag→swift-buildfor better parameter naming - Adds backward compatibility support with deprecation warnings for old parameters
- Implements parameter validation to prevent mixing old and new parameter sets
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| action.yml | Updates parameter definitions, adds deprecation handling and validation logic, and converts all references to use resolved environment variables |
| README.md | Updates documentation to reflect new parameter names and adds deprecation notices |
| .github/workflows/test-install.yml | Updates test workflows to use new parameter names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
branchandtagtoswift-versionandswift-buildto aid in clarity.Fixes: #19