Refactor: organize user commands #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
since this is calculated dynamically from source and could be 'dirty' based on work in progress
thekaveman
force-pushed
the
refactor/user
branch
2 times, most recently
from
972974a to
920d04d
Compare
adjusts all user commands to be subcommands, with usage: $ compiler-admin user <subcommand> <subcommand args>
avoids matching on string names, simplifies adding new commands
thekaveman
force-pushed
the
refactor/user
branch
from
920d04d to
5d94c0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR organizes all
usercommands:user/subdirectory incommands/usercommand on the CLIE.g. before this change, to create a user the following CLI call was used:
And after this change, the call looks like:
This PR also updates how argument parsers are built and evaluated for the CLI, to give more flexibility to additional top-level commands in the future.