Skip to content

Refactoring build_interpreter function #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Refactoring build_interpreter function #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/xutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,16 @@ namespace xcpp

interpreter_ptr build_interpreter(int argc, char** argv)
{
int interpreter_argc = argc; // + 1;
const char** interpreter_argv = new const char*[interpreter_argc];
std::vector<const char*> interpreter_argv(argc);
interpreter_argv[0] = "xeus-cpp";
// Copy all arguments in the new array excepting the process name.

// Copy all arguments in the new vector excepting the process name.
for (int i = 1; i < argc; i++)
{
interpreter_argv[i] = argv[i];
}

interpreter_ptr interp_ptr = std::make_unique<interpreter>(interpreter_argc, interpreter_argv);
delete[] interpreter_argv;
interpreter_ptr interp_ptr = std::make_unique<interpreter>(argc, interpreter_argv.data());
return interp_ptr;
}

Expand Down