Skip to content

Conversation

anutosh491
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (e702dd9) to head (3d0ddcf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files          19       19           
  Lines         973      973           
  Branches       93       93           
=======================================
  Hits          786      786           
  Misses        187      187           
Files with missing lines Coverage Δ
src/xinterpreter.cpp 91.35% <ø> (ø)
Files with missing lines Coverage Δ
src/xinterpreter.cpp 91.35% <ø> (ø)
---- 🚨 Try these New Features:

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@anutosh491
Copy link
Collaborator Author

I suspect there would be more in other files but I'll keep removing them as and when I encounter them. This was something that I could see right away.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please use squash on merge.

@anutosh491 anutosh491 merged commit 859a1b9 into main Nov 19, 2024
10 checks passed
@anutosh491 anutosh491 deleted the anutosh491-patch-2 branch November 19, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants