Fix logic for resource dir flag #168
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 80.14% 80.76% +0.61%
==========================================
Files 19 19
Lines 972 972
Branches 93 93
==========================================
+ Hits 779 785 +6
+ Misses 193 187 -6
|
vgvassilev
reviewed
Nov 5, 2024
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Nov 5, 2024
| std::cerr << "Failed to detect the resource-dir\n"; | ||
| } | ||
| ClangArgs.push_back("-resource-dir"); | ||
| ClangArgs.push_back(resource_dir.c_str()); |
There was a problem hiding this comment.
Please make this patch one line as it should be.
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Closing as completed in #169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for the resource dir flag looks corrupt.
I am guessing we need to check if the flag is available, if not we need CppInterOp to fetch it for us. If flag is found add the arguments else return error.