Skip to content

Conversation

mcbarton
Copy link
Collaborator

Due to the introduction to code completion the minimum version of CppInterOp needed is 1.3.0 . This PR introduces this fix. @vgvassilev This PR is ready for review.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.83%. Comparing base (f2d118d) to head (539c6ea).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   57.83%   57.83%           
=======================================
  Files          15       15           
  Lines         600      600           
  Branches       59       59           
=======================================
  Hits          347      347           
  Misses        253      253           

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks !

@anutosh491 anutosh491 merged commit 85721f2 into compiler-research:main May 19, 2024
@mcbarton mcbarton deleted the upgrade-minimum-CppInterOp-to-1.3.0 branch May 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants