Improve binary message handling #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced the parse frame method to deal with binary messages and properly account for content length.
This reverts commit da77eac.
…ocality and reduce function call overhead.
… improved buffer management and state tracking.
…header processing during frame parsing.
…em at correct processing points.
…ess with comprehensive NULL byte and content-length tests.
…of empty bytes for better null handling.
…in __init__ instead of using dataclass field declarations.
giyokun
commented
Sep 2, 2025
|
Does it work though?) Can you check that? |
|
OK. I am not very knowledgeable in this. Let me see how I can pull back
your changes into my tree and I will test.
cheers
G
…On Tue, Sep 2, 2025, 14:29 Lev Vereshchagin ***@***.***> wrote:
*vrslev* left a comment (community-of-python/stompman#145)
<#145 (comment)>
Does it work though?) Can you check that?
—
Reply to this email directly, view it on GitHub
<#145 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AECVLHSUAHQ5UEYMEPMHZI33QUTMXAVCNFSM6AAAAACFAUYBNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENBTHAZTAMZZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I have tested now and it seems everything works as it should. |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced the parse frame method to deal with binary messages and properly account for content length.