Skip to content

Conversation

@dear-ore
Copy link
Contributor

It should be stated that comments start with #. While I understand that lines that start with # are comments, I don't feel it should be assumed that everyone will know.

It should be stated that comments start with #. While I understand  that lines that start with # are comments, I don't feel it should be assumed that everyone will know.
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this being added if others find it useful. But the link in the same paragraph about Yaml should have more info about comments as well (users are expected to follow that if they are not already familiar with Yaml).

@dear-ore
Copy link
Contributor Author

Oh, I only just understood your reply. The link about YAML really does have a topic about comments.

@swzCuroverse
Copy link
Contributor

@dear-ore do you want to close this out then and not make the change?

@dear-ore
Copy link
Contributor Author

I would like to make the change if allowed. Since it's a quick start guide, people may want to rush through before settling with the yaml guide.

@mr-c mr-c merged commit f9e63da into common-workflow-language:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants