fixed broken link #274
fixed broken link #274
Conversation
swzCuroverse
left a comment
swzCuroverse
left a comment
There was a problem hiding this comment.
https://docs.github.com/en/get-started/quickstart/contributing-to-projects --> did we want this instead since it is off of the main doc fro github?
|
yes. i think it's better to use that link! |
I agree too that the GitHub link would be better. @bamiwoaluko can you update the pull request, please? |
will do! |
kinow
left a comment
kinow
left a comment
There was a problem hiding this comment.
@bamiwoaluko look at the very end of this document. There is a line like this one [how-contribute]: ..... That's where we should update it 😉
| ## Using GitHub | ||
|
|
||
| If you choose to contribute via GitHub, you may want to look at | ||
| [How to Contribute to an Open Source Project on GitHub][how-contribute]. |
There was a problem hiding this comment.
][how-contribute].... this is an alias for a link. The actual link is at the end of this document, along with several other links. That's useful in case we need to use the link in multiple places (but update a single place) and also to reduce cluttering in the source.
kinow
left a comment
kinow
left a comment
There was a problem hiding this comment.
Looks good to me! @bamiwoaluko are you familiar with git and squashing commits? If so you could perhaps try to squash the commits in this PR as there are now 4 commits, but for a small change like this one would be better to have a single commit (easier for others to compare changes later if needed). If you are not sure how to do it, a reviewer can squash it for you when they are ready to merge it 👍 Thanks!
initial link on how to contribute to an open project led to a 404 page. I replaced it with a link to lead to the correct pages
4 participants
initial link on how to contribute to an open project led to a 404 page. I replaced it with a link to lead to the correct pages