Skip to content

Conversation

@kinow
Copy link
Member

@kinow kinow commented Aug 26, 2022

Closes #209

@kinow kinow requested a review from mr-c August 26, 2022 00:43
hello.txt
```

And now invoke `cwl-runner` with the tool wrapper and the input object on the command line:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An addition to the style guide, use "tool description" not "tool wrapper"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, will fix it and update the style guide too. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description not descriptor :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I went to do a quick self-edit of what I wrote, and realized it. Then I tried fixing that after rebasing, and wrote “Use tool description, not tool description”. Then fixed that and messed up somewhere else. Argh. Hopefully fixed now 🤞

@kinow kinow requested a review from mr-c August 26, 2022 09:44
@kinow kinow force-pushed the fix-209 branch 3 times, most recently from f17e1c6 to 1ab3756 Compare August 26, 2022 09:48
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mr-c mr-c enabled auto-merge (squash) August 26, 2022 09:50
@mr-c mr-c merged commit 84f22ab into main Aug 26, 2022
@mr-c mr-c deleted the fix-209 branch August 26, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ep4: Commands and output mixed into same code box

3 participants