-
-
Notifications
You must be signed in to change notification settings - Fork 65
Made licensing guideline more neutral #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mr-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.commonwl.org/user_guide/rec-practices/ is a list of recommended practices, the point is to give people good defaults to work from, so that is why we recommend a specific license.
Mentioning SoftwareRequirement here doesn't seem helpful.
As of right now I'm not motivated to merge this PR. Other perspectives are welcome.
|
Yes, we shouldn't :) It's like the C++ committee saying all C++ code should be released under MIT. It's not our place to do that. Which is why I linked to a published paper with guidelines for licensing for our intended audience. :) |
The CWL committee is over at https://github.com/common-workflow-language/common-workflow-language/ This is the CWL community :-) |
|
This is is a list of recommendations for writing a program. It should be neutral as to political points. I'm happy to advocate with you on another forum for political points like pushing the Apache 2.0 license. My current personal favorite for hobby projects is MIT (almost the same as Apache 2.0) but that is a separate issue. But to advocate for a particular license in a site devoted to educating people about the use of a software specification is misleading. It is important that users educate themselves about software licenses, understand the intent of all licenses and decide for themselves what matches their goals. |
|
Our recommended practices (not the specification!) should rightfully be opinionated on this. I think it's a good idea from our recommended practices to link to other recommended practices like A Quick Guide to Software Licensing for the Scientist-Programmer I think we should still recommend a default license and keep it at Apache 2.0 - as CWL workflows are likely to be mixed and merged we don't want a big flora of licenses as this just causes combinatorics problems. Perhaps we can word it a bit more positive, like "to encourage re-use, re-purposing and combinations of the workflow across the CWL community if the workflow is made public, assign it an open source license like Apache 2.0". It might be worth pointing out that the license of the CWL workflow and its tool descriptions often will differ from the license of the tool it invokes (or even more complicated - the docker image that is distributed in). In https://view.commonwl.org/about#licensing we say
In the rendering we try to pick up the
(That is making an unfair assumption that anything with a |
|
@stain @mr-c thanks for commenting
I agree to the extent that we should point users to educate themselves and think about consequences. I linked to a PLoS paper in the P-R but a website is fine too. Advocacy as to legal things, like licenses, I'm not comfortable with in an official document.
Oh yes, that's a hairy point. Whether you can actually run the CWL also depends on the license of the container or other software you depend on. This is why I included a statement about |
|
@stain I agree that we could/should expand on our reasoning. However I want to keep this closer to a checklist, so maybe we should split off the justification/background to footnotes or another document (same structure, but more verbose) |
|
Did you reach a conclusion on this? My summary is that you agree on adding a link to some resource where users can learn more about choosing a license (I too like the PLOS paper that Kaushik linked to) but disagree on how opinionated the language should be around recommending a permissive license. May I suggest a compromise? (emphasis added to distinguish my suggested changes)
|
Co-authored-by: Kaushik Ghose <[email protected]>
and apply suggestions from @tobyhodges
❌ Deploy Preview for trusting-gates-d1169f failed.
|
I think CWL should not prescribe a particular license. We should simply raise the issue that, like all software, CWL documents need a license to avoid problems and confusion for users.