Added nested scatter conformance tests #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
approved these changes
Jun 21, 2022
kinow
approved these changes
Jun 21, 2022
Member
kinow
left a comment
kinow
left a comment
There was a problem hiding this comment.
Loved the detail in these tests @GlassOfWhiskey 👏 +1
kinow
pushed a commit
to kinow/cwl-v1.2
that referenced
this pull request
Oct 20, 2022
GlassOfWhiskey
added a commit
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing nested scatter configurations with simple scatter, dot-product, flat cross-product and nested cross-product in various combinations.
These tests constitute a baseline that can either be expanded with more combinations (e.g. hybrid dot-product+cross-product configurations) or reduced if too detailed.
A side note: 4 different
scatterX-job.ymlfiles are provided, but if a WMS correctly skips unused inputs a single file (the actualscatter4-job.yml) would be sufficient for all the test cases.