Skip to content

Conversation

callumacrae
Copy link

@callumacrae callumacrae commented Jul 15, 2020

Following #609, it looks like it happened again - there was another issue in findup-sync!

PR fixing the issue on find-node-modules: callumacrae/find-node-modules#11

[email protected] has dropped support for node 8, but looking at your README it doesn't look like that will be an issue.

(also this PR was my first time using commitizen - I liked it! 😆)

Copy link
Contributor

@jimmyandrade jimmyandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mybrainishuge
Copy link

Looks like this can be closed since #808 supersedes it with a newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants