Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Feb 4, 2021

Description

originally, we use "----------commit-delimiter----------" to split git command result and strip them which should be "\n----------commit-delimiter----------\n" instead.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Proceed as usual if users do not provide their email or commit message in their commit history

Steps to Test This Pull Request

  1. Create an empty project
  2. git init
  3. touch test-file
  4. git commit --author="Name <>" -m "whatever"
  5. touch another-test-file
  6. git commit --author="Name <>" -m "" --allow-empty

Additional context

#340

@Lee-W Lee-W requested a review from woile February 4, 2021 11:11
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #341 (f01a03c) into master (1a33099) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   97.20%   97.29%   +0.09%     
==========================================
  Files          35       35              
  Lines        1000      999       -1     
==========================================
  Hits          972      972              
+ Misses         28       27       -1     
Flag Coverage Δ
unittests 97.29% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/cli.py 97.50% <ø> (ø)
commitizen/commands/init.py 91.66% <ø> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/bump.py 94.44% <100.00%> (ø)
commitizen/config/yaml_config.py 100.00% <100.00%> (ø)
commitizen/git.py 96.62% <100.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef5257...f01a03c. Read the comment docs.

@woile woile merged commit b901bea into master Feb 6, 2021
@woile woile deleted the fix-git-message-parsing branch February 6, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants