Skip to content

Conversation

@josix
Copy link
Contributor

@josix josix commented Sep 1, 2020

Description

Add different commit messages including major, minor, patch increment and optional scope in messages to bump command testing.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

All test cases should pass as usual

Steps to Test This Pull Request

Just running pytest tests/commands/test_bump_command.py

Additional context

#127

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #257 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   96.60%   96.61%   +0.01%     
==========================================
  Files          33       33              
  Lines         912      915       +3     
==========================================
+ Hits          881      884       +3     
  Misses         31       31              
Flag Coverage Δ
#unittests 96.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/cli.py 97.36% <ø> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/check.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b207e6d...b26f408. Read the comment docs.

@josix josix marked this pull request as ready for review September 1, 2020 18:57
@woile
Copy link
Member

woile commented Sep 1, 2020

Nice work!!

@Lee-W Is this enough to close the issues? What do you think?

@woile woile merged commit 6efb23f into commitizen-tools:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants