Drop custom separator in favor of default colon (:)
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dot is unreserved character, however the representation in browsers (`%2E` or `.`), mail clients and even SMTP-servers is not unified and can lead to different issues: - https://wordtothewise.com/2018/11/why-do-my-urls-have-two-dots/ - https://bugs.python.org/issue43922 Also, Django is using dot for some funky JSON compression in `django.core.signing`: https://github.com/django/django/blob/4f8c7fd9d91b35e2c2922de4bb50c8c8066cbbc6/django/core/signing.py#L29-L30 So, in this PR I am suggesting to drop custom separator and switch to the default colon (`:`). It is also not reserved of anything in domain path, but only in host and scheme parts. - https://www.rfc-editor.org/rfc/rfc3986#section-3.3 - https://security.stackexchange.com/questions/159099/colons-in-urls-safe
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 333 331 -2
=========================================
- Hits 333 331 -2
Continue to review full report at Codecov.
|
Django versions <3 have no compatibility with psycopg-binary>=2.9. django/django#14530 I'd be up for dropping Django 2.2 completely, as it is now only receiving security support, but we also can wait until April and simply pin psycopg-binary in CI until then (as I would not expect anything breaking because of that).
codingjoe
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dot is unreserved character, however the representation in browsers (
%2Eor.), mail clients and even SMTP-servers is not unified and can lead to different issues:Also, Django is using dot for some funky JSON compression in
django.core.signing:https://github.com/django/django/blob/4f8c7fd9d91b35e2c2922de4bb50c8c8066cbbc6/django/core/signing.py#L29-L30
So, in this PR I am suggesting to drop custom separator and switch to the default colon (
:).It is also not reserved of anything in domain path, but only in host and scheme parts.