-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(signout): Fixing UI updates after sign out #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(signout): Fixing UI updates after sign out #891
Conversation
|
This is really nice @arthurdenner! Thank you so much for building this 😄. Merging it in now! |
|
@CompuIves, sorry for bothering you, but I saw that you reverted this PR and now the sign out is broken again. Also, is there any way to sign in with GitHub during development besides copying the |
|
Hey! We have to look at this one again, when deploying this one people weren't able to look at their sandbox when signed in (related #894, #893). I completely forgot that |
|
Sorry, I didn't notice this at all. |
|
@CompuIves, I looked at this problem again and noticed that if we use the Can you confirm this? |
What kind of change does this PR introduce?
Bug fix. Closes #852.
What is the current behavior?
After signing out, the UI breaks because the
UserMenucomponent is connected to the store and reacts to theuserproperty being updated. (See #852)What is the new behavior?
Instead of being connected to the store, the
UserMenucomponent receives theuseranduserMenuOpenprops from theNavigationcomponent, which also decides if theUserMenushould render or not based on theuserproperty.Checklist: