fix: force commonjs resolving for chevrotain #8688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After preferring esmodules in our export resolving, some sandboxes broke because of its reliance on
[email protected]. This version ofchevrotainhas a version of ESM where__esModuleis set to true, but where also a default export is set. This should not happen, if__esModuleis set to true, all of its exports should be on the root.Other bundlers also had issue with this, and as a result some libraries have updated
chevrotainto v11, which fixes the issue. We want to keep backwards compatibility on our sandboxes, though, so we should instead force commonjs resolving for chevrotain 10.x.x.An alternative solution is to alias chevrotain 10.x.x to 11.x.x