Skip to content

fix: test due to resolver changes #8687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: test due to resolver changes #8687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/sandpack-core/src/resolver/resolver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ describe('resolve', () => {
isFile,
readFile,
});
expect(resolved).toBe('/node_modules/solid-js/dist/solid.cjs');
expect(resolved).toBe('/node_modules/solid-js/dist/solid.js');
});

it('should fall back to index.js when it cannot find package.main', () => {
Expand Down Expand Up @@ -535,7 +535,7 @@ describe('resolve', () => {
isFile,
readFile,
});
expect(resolved).toBe('/node_modules/its-fine/out/index.cjs');
expect(resolved).toBe('/node_modules/its-fine/out/index.js');
});

it('resolve fflate correctly', () => {
Expand All @@ -545,7 +545,7 @@ describe('resolve', () => {
isFile,
readFile,
});
expect(resolved).toBe('/node_modules/fflate/lib/index.cjs');
expect(resolved).toBe('/node_modules/fflate/esm/browser.js');
});

// We should still post process imports using the browser field even when a package has exports
Expand Down
12 changes: 6 additions & 6 deletions packages/sandpack-core/src/resolver/utils/__snapshots__/pkg-json.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@
exports[`process package.json Should correctly handle nested pkg#exports fields (solid-js) 1`] = `
{
"aliases": {
"/node_modules/solid-js": "/node_modules/solid-js/dist/solid.cjs",
"/node_modules/solid-js": "/node_modules/solid-js/dist/solid.js",
"/node_modules/solid-js/dist/*": "/node_modules/solid-js/dist/$1",
"/node_modules/solid-js/dist/server.cjs": "/node_modules/solid-js/dist/solid.cjs",
"/node_modules/solid-js/dist/server.js": "/node_modules/solid-js/dist/solid.js",
"/node_modules/solid-js/h": "/node_modules/solid-js/h/dist/h.cjs",
"/node_modules/solid-js/h": "/node_modules/solid-js/h/dist/h.js",
"/node_modules/solid-js/h/dist/*": "/node_modules/solid-js/h/dist/$1",
"/node_modules/solid-js/html": "/node_modules/solid-js/html/dist/html.cjs",
"/node_modules/solid-js/html": "/node_modules/solid-js/html/dist/html.js",
"/node_modules/solid-js/html/dist/*": "/node_modules/solid-js/html/dist/$1",
"/node_modules/solid-js/store": "/node_modules/solid-js/store/dist/store.cjs",
"/node_modules/solid-js/store": "/node_modules/solid-js/store/dist/store.js",
"/node_modules/solid-js/store/dist/*": "/node_modules/solid-js/store/dist/$1",
"/node_modules/solid-js/universal": "/node_modules/solid-js/universal/dist/dev.cjs",
"/node_modules/solid-js/universal": "/node_modules/solid-js/universal/dist/dev.js",
"/node_modules/solid-js/universal/dist/*": "/node_modules/solid-js/universal/dist/$1",
"/node_modules/solid-js/web": "/node_modules/solid-js/web/dist/web.cjs",
"/node_modules/solid-js/web": "/node_modules/solid-js/web/dist/web.js",
"/node_modules/solid-js/web/dist/*": "/node_modules/solid-js/web/dist/$1",
},
"hasExports": true,
Expand Down
Loading