Skip to content

perf: dont resolve semver if it's already absolute #8621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024
Merged

perf: dont resolve semver if it's already absolute #8621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/sandpack-core/src/npm/dynamic/resolve-dependency.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import minimatch from 'minimatch';
import * as semver from 'semver';
import { isAbsoluteVersion } from '@codesandbox/common/lib/utils/dependencies';

import { ILambdaResponse } from '../merge-dependency';
import {
Expand All @@ -13,7 +14,10 @@ export async function getPackageJSON(dep: string, version: string) {
return m.code;
}

async function getLatestVersionForSemver(dep: string, version: string) {
async function getLatestVersionForSemver(
dep: string,
version: string
): Promise<string> {
const p = await getPackageJSON(dep, version);
return JSON.parse(p).version;
}
Expand All @@ -32,7 +36,11 @@ function getAbsoluteVersion(
depName: string,
depVersion: string,
parsedResolutions: { [name: string]: IParsedResolution[] }
) {
): Promise<string> {
if (isAbsoluteVersion(depVersion)) {
return Promise.resolve(depVersion);
}

// Try getting it from the resolutions field first, if that doesn't work
// we try to get the latest version from the semver.
const applicableResolutions = parsedResolutions[depName];
Expand All @@ -49,7 +57,7 @@ function getAbsoluteVersion(
return getLatestVersionForSemver(depName, range);
}

return range;
return Promise.resolve(range);
}
}

Expand Down