Skip to content

make proxy an option #6748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 15, 2022
Merged

make proxy an option #6748

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27d9f2c
make proxy an option
CompuIves Jun 15, 2022
f6a465c
Update RegistryForm.tsx
CompuIves Jun 15, 2022
ce0f862
.
CompuIves Jun 15, 2022
da87954
update
CompuIves Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion packages/app/src/app/pages/Dashboard/Content/routes/Settings/TeamSettings/RegistryForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
Icon,
Link,
Tooltip,
Switch,
} from '@codesandbox/components';
import {
AuthType,
Expand Down Expand Up @@ -94,6 +95,9 @@ export const RegistryForm = ({
const [scopes, setScopes] = React.useState<string[]>(
registry?.enabledScopes || []
);
const [proxyEnabled, setProxyEnabled] = React.useState(
registry?.proxyEnabled
);

const addScope = () => {
setScopes(oldScopes => [...oldScopes, '']);
Expand All @@ -118,7 +122,7 @@ export const RegistryForm = ({
enabledScopes: scopes.filter(s => s !== ''),
registryAuthType: authenticationType,
registryUrl,
proxyEnabled: true,
proxyEnabled,
});

// We make sure to always show one input field
Expand Down Expand Up @@ -200,6 +204,26 @@ export const RegistryForm = ({
setAuthKey={setAuthKey}
disabled={disabled}
/>

<div>
<CustomFormField
direction="horizontal"
label="Use the server proxy to access registry"
>
<Switch
onChange={() => {
setProxyEnabled(s => !s);
}}
on={proxyEnabled}
disabled={disabled}
/>
</CustomFormField>
<Text size={3} variant="muted">
Disabling the proxy will allow you to use the registry behind
a VPN, but will expose the auth token to the browser and
require a CORS setup.
</Text>
</div>
</Stack>
<Stack
align="center"
Expand Down