Skip to content

Conversation

@CompuIves
Copy link
Member

@CompuIves CompuIves commented Sep 8, 2020

3 things:

  1. A big devtool slowdown for console.log spam was actually updating the indicator, this debounces the update with 50ms. So it waits 50ms before committing the actual state change, if anything comes in within those 50ms the timer resets.
  2. We only show the last 500 console.log messages. An improvement, later on, would be to allow lazy loading.
  3. We now don't clear the console on hot reloads from the bundler, this was inconsistent behavior anyway.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 375d191:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr4863 September 8, 2020 20:55 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Sep 8, 2020

Build for latest commit 375d191 is at https://pr4863.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr4863 September 9, 2020 19:09 Inactive
@CompuIves CompuIves changed the title Debounce updating the status indicator of devtools Console Improvements Sep 9, 2020
@lbogdan lbogdan temporarily deployed to pr4863 September 9, 2020 19:25 Inactive
break;
}
case 'clear-console': {
if (this.state.initialClear) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized we don't use this anymore, and prevents first clear on the console.

Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please checkout the debounced thing 😄

Nagging about variable names.

Have not actually tested this, just looking at code

@lbogdan lbogdan temporarily deployed to pr4863 September 16, 2020 09:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants