Cleanup Server screen #4025
Merged
Cleanup Server screen #4025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build for latest commit b86d805 is at https://pr4025.build.csb.dev/s/new. |
MichaelDeBoey
force-pushed
the
cleanup/screens/Server
branch
2 times, most recently
from
6190abf to
6154fa3
Compare
SaraVieira
suggested changes
May 18, 2020
Contributor
SaraVieira
left a comment
SaraVieira
left a comment
There was a problem hiding this comment.
Hey!
Conflicts :(
Can you please not reorder attributes and imports? It makes it super hard to review the PR's as it looks away bigger than it is
MichaelDeBoey
force-pushed
the
cleanup/screens/Server
branch
from
6154fa3 to
28e2a7c
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b86d805:
|
MichaelDeBoey
force-pushed
the
cleanup/screens/Server
branch
from
28e2a7c to
b0357a2
Compare
Contributor
Author
|
@SaraVieira I've rebased onto |
Contributor
|
Restert buttons are not working, gonna pull and see whats up |
Contributor
Author
|
@SaraVieira If needed, I can look at it tomorrow 🙂 |
MichaelDeBoey
force-pushed
the
cleanup/screens/Server
branch
from
b0357a2 to
c52e421
Compare
MichaelDeBoey
force-pushed
the
cleanup/screens/Server
branch
from
c52e421 to
b86d805
Compare
Contributor
Author
|
@SaraVieira I've rebased onto |
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things I did:
deleteEnvironmentVariable's signature to accept astringinstead of{ name: string }, because it only has 1 argumentonBrowserFromPortOpened's signature to accept aServerPortinstead of{ port: ServerPort }, because it only has 1 argumentControl,EnvVars,Ports,Server,Status,Tasks&VarFormaFunctionComponentVarForm's propsVarForm'sonCancel&onSubmitfunctionsgetContainerStatusInfo&getManagerStatusInfoa bit inStatusgetIcona bit inTasks