Skip to content

Conversation

@CompuIves
Copy link
Member

@CompuIves CompuIves commented Apr 17, 2020

Might fix #3928
Might fix #3929
Might fix #3930

@jyash97
Copy link
Contributor

jyash97 commented Apr 17, 2020

Is this fix live? @CompuIves

I can confirm that dashboard is working now. Also, I was trying to fix this but not happening on local.

@lbogdan
Copy link
Contributor

lbogdan commented Apr 17, 2020

Build for latest commit 6bc6ff7 is at https://pr3931.build.csb.dev/s/new.

@CompuIves
Copy link
Member Author

Yeah, it doesn't seem to happen on local for some reason. We rolled back, so this might be the fix, but am unsure. We will know once this has been deployed to staging 😄

@CompuIves
Copy link
Member Author

Oh, speaking of the devil!

@CompuIves
Copy link
Member Author

CompuIves commented Apr 17, 2020

Dashboard seems to work on my side now, that's weird... Some babel transpilation probably broke this.

@jyash97
Copy link
Contributor

jyash97 commented Apr 17, 2020

I can give you some pointer here. This PR seems to break the dashboard: #3927

Try running yarn and test the app. Maybe it may break on local. My system is still starting the app 😕

@CompuIves
Copy link
Member Author

Yeah, I wasn't able to repro it in dev at the time. I think maybe some babel dependencies changed in that PR that caused this issue 🤔

@CompuIves CompuIves marked this pull request as ready for review April 17, 2020 16:03
@CompuIves
Copy link
Member Author

Okay, here we gooooo

@CompuIves CompuIves merged commit 108677a into master Apr 17, 2020
@CompuIves CompuIves deleted the fix/extra-elements branch April 17, 2020 16:03
@jyash97
Copy link
Contributor

jyash97 commented Apr 17, 2020

Curious to know what was the reason behind the issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash while logging out. 💥 Crash Report crash on trying to access dashboard

4 participants