Skip to content

🔨 Switch Live to use useOvermind #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2020
Merged

🔨 Switch Live to use useOvermind #3558

merged 1 commit into from
Sep 8, 2020

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Feb 20, 2020 •
edited
Loading

Follow-up of #3177 & #3208

Things I did extra:

  • Change signInToRoom & roomJoined's signatures to accept a string instead of { roomId: string }, because they only have 1 argument
  • Use FunctionComponent instead of React.FC, since it's the same, but FunctionComponent is a bit clearer I think
  • Put all styles into the elements.ts file
  • Extract Error, Loading & NotAuthenticated from Live
  • Remove BlinkingDot

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Feb 20, 2020
@lbogdan
Copy link
Contributor

lbogdan commented Feb 20, 2020 •
edited
Loading

Build for latest commit b485406 is at https://pr3558.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Live branch 2 times, most recently from 0917991 to 6087ff2 Compare February 23, 2020 17:07
@lbogdan lbogdan temporarily deployed to pr3558 February 23, 2020 17:19 Inactive
@lbogdan lbogdan temporarily deployed to pr3558 March 5, 2020 01:37 Inactive
@lbogdan lbogdan temporarily deployed to pr3558 March 8, 2020 16:19 Inactive
@lbogdan lbogdan temporarily deployed to pr3558 April 4, 2020 16:17 Inactive
@lbogdan lbogdan temporarily deployed to pr3558 April 4, 2020 16:59 Inactive
@lbogdan lbogdan temporarily deployed to pr3558 April 7, 2020 17:24 Inactive
@lbogdan lbogdan temporarily deployed to pr3558 April 21, 2020 23:57 Inactive
@lbogdan lbogdan temporarily deployed to pr3558 April 29, 2020 19:17 Inactive
@lbogdan lbogdan temporarily deployed to pr3558 April 30, 2020 13:50 Inactive
SaraVieira
SaraVieira suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heey!

Conflicts here :(

@MichaelDeBoey MichaelDeBoey requested a review from SaraVieira May 21, 2020 15:38
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 21, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b485406:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr3558 May 21, 2020 15:44 Inactive
@lbogdan lbogdan temporarily deployed to pr3558 July 2, 2020 23:00 Inactive
@lbogdan lbogdan temporarily deployed to pr3558 July 3, 2020 14:06 Inactive
@lbogdan lbogdan temporarily deployed to pr3558 September 4, 2020 16:31 Inactive
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Sep 4, 2020

@SaraVieira @christianalfoni I've rebased onto upstream/master, so this could be merged now 🙂

@SaraVieira SaraVieira merged commit 40d7518 into codesandbox:master Sep 8, 2020
@SaraVieira
Copy link
Contributor

SaraVieira commented Sep 8, 2020

Thank you!

@MichaelDeBoey MichaelDeBoey deleted the overmind/Live branch September 8, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianalfoni christianalfoni Awaiting requested review from christianalfoni

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @SaraVieira