Skip to content

🔨 Switch Profile/Header to use useOvermind #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2020
Merged

🔨 Switch Profile/Header to use useOvermind #3407

merged 2 commits into from
Feb 19, 2020

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jan 29, 2020

Things I did:

  • Put all styles into the elements.ts file
  • Move overmind subscriptions as close as possible to the components itself instead of passing it through
  • Export Header by a named export instead of a default export

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Jan 29, 2020
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from 5d8d0a0 to e909cbe Compare January 29, 2020 12:54
@lbogdan lbogdan temporarily deployed to pr3407 January 29, 2020 13:02 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Jan 29, 2020 •
edited
Loading

Build for latest commit ddd8036 is at https://pr3407.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from e909cbe to 217cb56 Compare January 29, 2020 13:20
@lbogdan lbogdan temporarily deployed to pr3407 January 29, 2020 13:29 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from 217cb56 to e1cef65 Compare January 30, 2020 23:45
@lbogdan lbogdan temporarily deployed to pr3407 January 30, 2020 23:51 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from e1cef65 to 7405e68 Compare January 31, 2020 13:36
@lbogdan lbogdan temporarily deployed to pr3407 January 31, 2020 13:43 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from 7405e68 to 93f934e Compare February 5, 2020 16:37
@lbogdan lbogdan temporarily deployed to pr3407 February 5, 2020 16:43 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from 93f934e to 97ad587 Compare February 5, 2020 23:34
@lbogdan lbogdan temporarily deployed to pr3407 February 5, 2020 23:40 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from 97ad587 to c70a59b Compare February 8, 2020 12:35
@lbogdan lbogdan temporarily deployed to pr3407 February 8, 2020 12:41 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from c70a59b to 55a2d7a Compare February 13, 2020 14:11
@lbogdan lbogdan temporarily deployed to pr3407 February 13, 2020 14:17 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from 55a2d7a to 45c4885 Compare February 13, 2020 14:40
@lbogdan lbogdan temporarily deployed to pr3407 February 13, 2020 14:46 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from 45c4885 to 1543ad7 Compare February 13, 2020 21:39
@lbogdan lbogdan temporarily deployed to pr3407 February 13, 2020 21:48 Inactive
SaraVieira
SaraVieira suggested changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with the contributor badge here
Screenshot 2020-02-13 at 23 57 17

Its supposed to be the same size

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from 1543ad7 to a9201a1 Compare February 18, 2020 17:32
@lbogdan lbogdan temporarily deployed to pr3407 February 18, 2020 17:37 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from a9201a1 to 12daf04 Compare February 18, 2020 17:43
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Profile-Header branch from 12daf04 to ddd8036 Compare February 18, 2020 17:48
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Feb 18, 2020

@SaraVieira Fixed ContributorsBadge's size 🙂

@SaraVieira
Copy link
Contributor

SaraVieira commented Feb 19, 2020

Awesome! Looks guuuuuddd

@SaraVieira SaraVieira merged commit 249b458 into codesandbox:master Feb 19, 2020
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Feb 19, 2020

With pleasure! 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/Profile-Header branch February 19, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SaraVieira SaraVieira SaraVieira requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @SaraVieira