Skip to content

🔨 Switch ForkServerModal to use useOvermind #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2020
Merged

🔨 Switch ForkServerModal to use useOvermind #3367

merged 1 commit into from
Jan 27, 2020

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jan 19, 2020

Follow-up of #2774

Things I did extra:

  • Put all styles into the elements.ts file
  • Use FunctionComponent instead of React.FC, since it's the same, but FunctionComponent is a bit clearer I think

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Jan 19, 2020
@lbogdan
Copy link
Contributor

lbogdan commented Jan 19, 2020

Build for latest commit 146b6c1 is at https://pr3367.build.csb.dev/s/new.

@SaraVieira
Copy link
Contributor

SaraVieira commented Jan 27, 2020

Nice! Thank you!

@SaraVieira SaraVieira merged commit efd92c8 into codesandbox:master Jan 27, 2020
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Jan 27, 2020

With pleasure! 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/ForkServerModal branch January 27, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @SaraVieira